Skip to content

BIRMINGHAM | ITP-MAY-25|Emin Akturk | MODULE-STRUCTURING #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

BIRMINGHAM | ITP-MAY-25|Emin Akturk | MODULE-STRUCTURING #617

wants to merge 11 commits into from

Conversation

eminakturk
Copy link

@eminakturk eminakturk commented Jun 27, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

I have commited new changes as CJ requested and fixed the related problems.

@eminakturk eminakturk added the Needs Review Participant to add when requesting review label Jun 27, 2025
cjyuan
cjyuan reviewed Jul 6, 2025
View reviewed changes
Sprint-1/3-mandatory-interpret/3-to-pounds.js

// 4. const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2): This line takes out the pounds part of the string.

// 5. const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0"): This line takes out pence part and pads it to 2 characters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just answer the question here.

@cjyuan
Copy link
Contributor

cjyuan commented Jul 6, 2025

  1. According to the Acceptance Criteria of Step 2 (https://programming.codeyourfuture.io/structuring-data/success/), you need to complete all three Sprint exercises (on separate branches, and submit in separate PRs).

  2. I restored the PR template in your PR description. Can you update it to include a brief description of this PR and check the checkboxes in the self-checklist?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 6, 2025
@eminakturk
Copy link
Author

Hello CJ!

Thank you for the review. I have fixed every error you mentioned.
I'm aware of sprint 3 needs to be done which I will be this week.

Also, I have fixed Pr template as you wished and ticked the checkboxes.

Thank you.

@eminakturk eminakturk added the Needs Review Participant to add when requesting review label Jul 7, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 7, 2025

Changes look good.

Leaving responses directly in the comment threads makes tracking the discussion easier. You can try the approach in future PRs.

image

Here is a simplified version of best practices ChatGPT suggested for responding to inline comments in a pull request:

  • ✅ Reply to every comment – Let the reviewer know you saw it.
  • ✏️ Make the change if needed – Fix the code if the comment points out a real issue.
  • 🤔 Explain if you don't agree – If you think the code is fine, politely explain why.
  • ✅ Mark as resolved when done – Only mark comments resolved after you fix or respond.
  • 💬 Keep replies short and polite – Be respectful and to the point.
  • ⏱️ Respond soon – Don’t wait too long to reply.
  • 🧪 Test your changes – Make sure your fixes actually work.
  • 📍 Reply directly under the comment – This keeps the conversation easy to follow.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eminakturk @cjyuan